You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/07/18 04:10:40 UTC
Review Request 12716: Fix for NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12716/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, edison su, Min Chen, Sateesh Chodapuneedi, and Sheng Yang.
Bugs: CLOUDSTACK-3598
Repository: cloudstack-git
Description
-------
Minor fix for an NPE when setting resource count.
Diffs
-----
engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java cfd2137
Diff: https://reviews.apache.org/r/12716/diff/
Testing
-------
This showed up in automation tests in the code path that handles template sync operations. I wasn't able to reproduce this in a manual setup. But the NPE does exist and the code needs to be fixed for that, so I'm submitting the patch.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request 12716: Fix for NPE
Posted by Sheng Yang <sh...@yasker.org>.
> On July 18, 2013, 3:54 p.m., Sheng Yang wrote:
> > Ship It!
Pushed to 4.2 and MASTER.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12716/#review23385
-----------------------------------------------------------
On July 18, 2013, 2:10 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12716/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 2:10 a.m.)
>
>
> Review request for cloudstack, Chip Childers, edison su, Min Chen, Sateesh Chodapuneedi, and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-3598
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Minor fix for an NPE when setting resource count.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java cfd2137
>
> Diff: https://reviews.apache.org/r/12716/diff/
>
>
> Testing
> -------
>
> This showed up in automation tests in the code path that handles template sync operations. I wasn't able to reproduce this in a manual setup. But the NPE does exist and the code needs to be fixed for that, so I'm submitting the patch.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request 12716: Fix for NPE
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12716/#review23385
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On July 18, 2013, 2:10 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12716/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 2:10 a.m.)
>
>
> Review request for cloudstack, Chip Childers, edison su, Min Chen, Sateesh Chodapuneedi, and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-3598
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Minor fix for an NPE when setting resource count.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java cfd2137
>
> Diff: https://reviews.apache.org/r/12716/diff/
>
>
> Testing
> -------
>
> This showed up in automation tests in the code path that handles template sync operations. I wasn't able to reproduce this in a manual setup. But the NPE does exist and the code needs to be fixed for that, so I'm submitting the patch.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>