[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15181: [opt](vectorized) opt the null map _has_null logic

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15181:
URL: https://github.com/apache/doris/pull/15181#discussion_r1052202064


##########
be/src/vec/columns/column_nullable.h:
##########
@@ -147,7 +147,7 @@ class ColumnNullable final : public COWHelper<IColumn, ColumnNullable> {
 
     void insert_many_defaults(size_t length) override {
         get_nested_column().insert_many_defaults(length);
-        _get_null_map_data().resize_fill(get_null_map_data().size() + length, 1);
+        _get_null_map_data().resize_fill(_get_null_map_data().size() + length 1);

Review Comment:
   warning: expected ')' [clang-diagnostic-error]
   ```cpp
           _get_null_map_data().resize_fill(_get_null_map_data().size() + length 1);
                                                                                 ^
   ```
   **be/src/vec/columns/column_nullable.h:149:** to match this '('
   ```cpp
           _get_null_map_data().resize_fill(_get_null_map_data().size() + length 1);
                                           ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org