You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kw...@apache.org on 2025/10/13 14:25:09 UTC
(maven-resolver) branch feature/request-timeout created (now 70fa8b017)
This is an automated email from the ASF dual-hosted git repository.
kwin pushed a change to branch feature/request-timeout
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
at 70fa8b017 Set the request timeout with Java HTTP Client
This branch includes the following new commits:
new 70fa8b017 Set the request timeout with Java HTTP Client
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(maven-resolver) 01/01: Set the request timeout with Java HTTP Client
Posted by kw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kwin pushed a commit to branch feature/request-timeout
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
commit 70fa8b017b4d24d0faefc17171ea586d305ce8f0
Author: Konrad Windszus <kw...@apache.org>
AuthorDate: Mon Oct 13 16:24:59 2025 +0200
Set the request timeout with Java HTTP Client
Although only considered until the response header is received
(https://bugs.openjdk.org/browse/JDK-8208693) this is better than no
timeout at all
This closes #1631
---
.../main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java | 4 ++++
.../java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java | 5 -----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java
index 2ac828e2b..316c073da 100644
--- a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java
+++ b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java
@@ -533,6 +533,10 @@ final class JdkTransporter extends AbstractTransporter implements HttpTransporte
CONFIG_PROP_HTTP_VERSION)))
.followRedirects(HttpClient.Redirect.NORMAL)
.connectTimeout(Duration.ofMillis(connectTimeout))
+ // this only considers the time until the response header is received, see
+ // https://bugs.openjdk.org/browse/JDK-8208693
+ // but better than nothing
+ .requestTimeout(Duration.ofMillis(requestTimeout))
.sslContext(sslContext);
if (insecure) {
diff --git a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
index 1f2976072..dd166935c 100644
--- a/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
+++ b/maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java
@@ -99,11 +99,6 @@ class JdkTransporterTest extends HttpTransporterTest {
@Test
protected void testPut_Authenticated_ExpectContinueRejected_ExplicitlyConfiguredHeader() {}
- @Override
- @Disabled
- @Test
- protected void testRequestTimeout() throws Exception {}
-
public JdkTransporterTest() {
super(() -> new JdkTransporterFactory(standardChecksumExtractor(), new DefaultPathProcessor()));
}