You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by bo...@apache.org on 2008/06/13 02:11:13 UTC
svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Author: bojan
Date: Thu Jun 12 17:11:13 2008
New Revision: 667300
URL: http://svn.apache.org/viewvc?rev=667300&view=rev
Log:
Also make it (ODBC DBD) link :-)
Modified:
apr/apr-util/trunk/build/dbd.m4
Modified: apr/apr-util/trunk/build/dbd.m4
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/build/dbd.m4?rev=667300&r1=667299&r2=667300&view=diff
==============================================================================
--- apr/apr-util/trunk/build/dbd.m4 (original)
+++ apr/apr-util/trunk/build/dbd.m4 Thu Jun 12 17:11:13 2008
@@ -465,7 +465,7 @@
dnl Since we have already done the AC_CHECK_LIB tests, if we have it,
dnl we know the library is there.
if test "$apu_have_odbc" = "1"; then
- LDADD_dbd_odbc="$odbc_LDFLAGS -lpq $odbc_LIBS"
+ LDADD_dbd_odbc="$odbc_LDFLAGS -lodbc $odbc_LIBS"
fi
AC_SUBST(LDADD_dbd_odbc)
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Thu, 2008-06-12 at 21:14 -0400, Tom Donovan wrote:
> All set on Windows now - r667309
Thanks!
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Tom Donovan <do...@bellatlantic.net>.
Bojan Smojver wrote:
> On Fri, 2008-06-13 at 10:26 +1000, Bojan Smojver wrote:
>
> It would be good if Windows folks could check this change that I made:
> ----------------------
> #ifdef HAVE_SQL_H
All set on Windows now - r667309
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2008-06-13 at 10:26 +1000, Bojan Smojver wrote:
> I have no idea if it actually works (it does compile and link).
It would be good if Windows folks could check this change that I made:
----------------------
#ifdef HAVE_SQL_H
#include <sql.h>
#include <sqlext.h>
#elif defined(HAVE_ODBC_SQL_H)
#include <odbc/sql.h>
#include <odbc/sqlext.h>
#endif
----------------------
No idea how these things get defined there.
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Thu, 2008-06-12 at 19:17 -0500, William A. Rowe, Jr. wrote:
> This is looking great, do we feel it's ready for people to try out with
> apr 1.3.1?
I have no idea if it actually works (it does compile and link). But hey
- that's how we'll find out :-)
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Thu, 2008-06-12 at 22:35 -0500, William A. Rowe, Jr. wrote:
> Sorry about that ... grrr.
This is not your fault. FreeTDS driver is busted on the inside as well.
We just never noticed anything because it NEVER got compiled. And I mean
EVER.
Trying to address now...
PS. ODBC driver doesn't build either. I'll look at that next.
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Bojan Smojver wrote:
> On Thu, 2008-06-12 at 23:14 -0400, Tom Donovan wrote:
>
>> I changed APU_DECLARE_DATA to APU_MODULE_DECLARE_DATA when I checked it into apr (copying the mysql
>> driver). Am I missing something?
>
> Sadly, nothing. The whole build thing is busted - even for FreeTDS
> driver. I'm fixing now.
Sorry about that ... grrr.
APU_DECLARE_DATA are exports from libaprutil-1.[so|sl|dll|dylib] itself, but
were never for exporting modules from any other module (such as an extra
add-in). APU_MODULE_DECLARE_DATA was added to cover the generic case of
unconditionally exporting from any library module.
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Thu, 2008-06-12 at 23:14 -0400, Tom Donovan wrote:
> I changed APU_DECLARE_DATA to APU_MODULE_DECLARE_DATA when I checked it into apr (copying the mysql
> driver). Am I missing something?
Sadly, nothing. The whole build thing is busted - even for FreeTDS
driver. I'm fixing now.
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Tom Donovan <do...@bellatlantic.net>.
Bojan Smojver wrote:
> On Thu, 2008-06-12 at 19:17 -0500, William A. Rowe, Jr. wrote:
>
>> This is looking great, do we feel it's ready for people to try out with
>> apr 1.3.1?
>
> Tom,
>
> Do you have an opinion on this?
>
> PS. I would personally prefer to see ODBC DBC in 1.3.1.
>
It's seen considerable use during its life in googlecode, so I think it is functionally solid.
I need to rely on you guys for the apr build & integration stuff. It's all new to me.
Has anyone else actually tested it yet with real data?
I've tested the apr version today on Windows. No problems.
On Linux, building httpd/apr/apr-util trunk with --with-odbc builds OK, but
lib/apr-util-1/apr_dbd_odbc-1.so seems to be missing its entry name: apr_dbd_odbc_driver.
I changed APU_DECLARE_DATA to APU_MODULE_DECLARE_DATA when I checked it into apr (copying the mysql
driver). Am I missing something?
-tom-
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by Bojan Smojver <bo...@rexursive.com>.
On Thu, 2008-06-12 at 19:17 -0500, William A. Rowe, Jr. wrote:
> This is looking great, do we feel it's ready for people to try out with
> apr 1.3.1?
Tom,
Do you have an opinion on this?
PS. I would personally prefer to see ODBC DBC in 1.3.1.
--
Bojan
Re: svn commit: r667300 - /apr/apr-util/trunk/build/dbd.m4
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
bojan@apache.org wrote:
> Author: bojan
> Date: Thu Jun 12 17:11:13 2008
> New Revision: 667300
>
> URL: http://svn.apache.org/viewvc?rev=667300&view=rev
> Log:
> Also make it (ODBC DBD) link :-)
:)
This is looking great, do we feel it's ready for people to try out with
apr 1.3.1?
Bill