[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #485: [ISSUE-484] Fix accidentally remove the storage of appId when unregistering partial shuffle in HdfsStorageManager

[GitBox <gi...@apache.org>]

zuston commented on code in PR #485:
URL: https://github.com/apache/incubator-uniffle/pull/485#discussion_r1070749767


##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -84,31 +84,32 @@ public Storage selectStorage(ShuffleDataReadEvent event) {
   @Override
   public void removeResources(PurgeEvent event) {
     String appId = event.getAppId();
-    String user = event.getUser();
     HdfsStorage storage = getStorageByAppId(appId);
-    if (storage != null) {
-      if (event instanceof AppPurgeEvent) {
-        storage.removeHandlers(appId);
-      }
+    if (storage == null) {

Review Comment:
   I want to log this null exception, which is related with this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org