[GitHub] [cordova-plugin-inappbrowser] AdriVanHoudt commented on issue #795: .open does not support windowFeatures with no `=` in them

[GitBox <gi...@apache.org>]

AdriVanHoudt commented on issue #795:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/795#issuecomment-747569769


   This is what we kinda do atm
   ```js
   // We want the inAppBrowser to handle our opens on mobile
   // This is needed to make tel: links work on iOS for example
   // This was removed from the plugin itself in https://github.com/apache/cordova-plugin-inappbrowser/pull/600
   $window.open = function open(url, target, windowFeatures) {
   
       // noopener and noreferrer are not supported by the inAppBrowser
       // It even crashes on Android https://github.com/apache/cordova-plugin-inappbrowser/issues/795
       if (windowFeatures) {
           windowFeatures = windowFeatures.replace(/noopener|noreferrer/g, '');
       }
   
        return cordova.InAppBrowser.open(url, target, windowFeatures);
   };
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org