You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/03/07 01:37:09 UTC
[kudu-CR] [ts recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6279
Change subject: [ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
......................................................................
[ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
This test expects a log roll before crashing, but with log compression
enabled we can actually write a lot of data before rolling. This is
making the test fail later with a timeout on Restart().
This patch disables log compression for this test, making sure that
we don't write as much and thus making restart faster.
Change-Id: I208fc1fb05dcb0cd6f5386792efc66e5e24272de
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/6279/1
--
To view, visit http://gerrit.cloudera.org:8080/6279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I208fc1fb05dcb0cd6f5386792efc66e5e24272de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] [ts recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
......................................................................
[ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
This test expects a log roll before crashing, but with log compression
enabled we can actually write a lot of data before rolling. This is
making the test fail later with a timeout on Restart().
This patch disables log compression for this test, making sure that
we don't write as much and thus making restart faster.
Change-Id: I208fc1fb05dcb0cd6f5386792efc66e5e24272de
Reviewed-on: http://gerrit.cloudera.org:8080/6279
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/ts_recovery-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I208fc1fb05dcb0cd6f5386792efc66e5e24272de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [ts recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSegmentHeader
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I208fc1fb05dcb0cd6f5386792efc66e5e24272de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No