[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #6885: GEODE-9570: make sure re-authentication works with registered interests

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #6885:
URL: https://github.com/apache/geode/pull/6885#discussion_r713258874



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUserAuths.java
##########
@@ -99,19 +98,20 @@ public Subject getSubject(final Long userId) {
     return uniqueIdVsSubject.get(userId);
   }
 
-  public boolean removeSubject(final Long userId) {
-    final Subject subject = uniqueIdVsSubject.remove(userId);
+  public void removeSubject(final Long userId) {
     logger.debug("Subject of {} removed.", userId);
+    removeSubject(uniqueIdVsSubject.remove(userId));
+  }
+
+  @VisibleForTesting
+  void removeSubject(Subject subject) {

Review comment:
       I would really like to see the increased use of `@Nullable`, and `@NotNull`, annotation where appropriate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org