You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/10/04 16:48:13 UTC

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8205


Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................

IMPALA-6012: workaround - downgrade hive temporarily

To unblock build, switch back to an older version of Hive
without HIVE-12730.

Testing:
Ran test_ddl.py as a smoke test. Will do more testing concurrent with
review.

Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/8205/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8205/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8205/1//COMMIT_MSG@11
PS1, Line 11: 
May be add that this should be reverted once HIVE-17189 makes it to the dependencies?



-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 16:57:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 2: Verified+1 Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 20:51:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1298/


-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Wed, 04 Oct 2017 16:48:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Dimitris Tsirogiannis, Alex Behm, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8205

to look at the new patch set (#2).

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................

IMPALA-6012: workaround - downgrade hive temporarily

To unblock build, switch back to an older version of Hive
without HIVE-12730. This should be reverted once HIVE-17189
makes it into the dependencies.

Testing:
Ran test_ddl.py as a smoke test. Will do more testing concurrent with
review.

Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/8205/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 1: Code-Review-2

Running tests but don't want to merge yet.


-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 16:48:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8205/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8205/1//COMMIT_MSG@11
PS1, Line 11: 
> May be add that this should be reverted once HIVE-17189 makes it to the dep
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 17:32:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 2:

I carried the verification since it was only a commit message change.


-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 20:51:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Oct 2017 20:49:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6012: workaround - downgrade hive temporarily

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8205 )

Change subject: IMPALA-6012: workaround - downgrade hive temporarily
......................................................................

IMPALA-6012: workaround - downgrade hive temporarily

To unblock build, switch back to an older version of Hive
without HIVE-12730. This should be reverted once HIVE-17189
makes it into the dependencies.

Testing:
Ran test_ddl.py as a smoke test. Will do more testing concurrent with
review.

Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Reviewed-on: http://gerrit.cloudera.org:8080/8205
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71cd293df1fc84429b23c94ad5c0564aa627a9a8
Gerrit-Change-Number: 8205
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>