You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/08/06 16:20:30 UTC
[GitHub] [fineract] danishjamal104 opened a new pull request #1810: groups list and accountNo field data type fixed in swagger resource (FINERACT-1364)
danishjamal104 opened a new pull request #1810:
URL: https://github.com/apache/fineract/pull/1810
## Description
- While fetching the client data the list of group(Object) is returned but in swagger resource the List<String> is defined. Hence fixed this issue by changing the type of field groups
- `accountNo` field in loan/savings account is defined as Long but returned is String. Fixed this issue.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] danishjamal104 commented on pull request #1810: groups list and accountNo field data type fixed in swagger resource (FINERACT-1364)
Posted by GitBox <gi...@apache.org>.
danishjamal104 commented on pull request #1810:
URL: https://github.com/apache/fineract/pull/1810#issuecomment-907805720
> LGTM... I think there may be some other possible fields in GetClientsGroups but this is definitely an improvement over the previous version.
>
> Though it would be great to get integration tests for all of these included in the build :-)
Yes, since I am working with the SDK integration in one of the MIFOS's client application, I am encountering more and more errors in swagger resources, so Ill keep fixing them in future with the proper test implementation also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1810: groups list and accountNo field data type fixed in swagger resource (FINERACT-1364)
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1810:
URL: https://github.com/apache/fineract/pull/1810#issuecomment-895278954
@Sanyam96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1810: groups list and accountNo field data type fixed in swagger resource (FINERACT-1364)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1810:
URL: https://github.com/apache/fineract/pull/1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org