You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zhu Zhu (Jira)" <ji...@apache.org> on 2023/02/23 08:55:00 UTC
[jira] [Closed] (FLINK-28294) Some metric reporters don't allow register same metric with different names
[ https://issues.apache.org/jira/browse/FLINK-28294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhu Zhu closed FLINK-28294.
---------------------------
Resolution: Duplicate
It is a duplicate issue of FLINK-30246.
The specific problem of `fullRestarts`&`numRestarts` is fixed via FLINK-30558.
> Some metric reporters don't allow register same metric with different names
> ---------------------------------------------------------------------------
>
> Key: FLINK-28294
> URL: https://issues.apache.org/jira/browse/FLINK-28294
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Metrics
> Affects Versions: 1.15.0
> Reporter: Xuannan Su
> Priority: Major
>
> Currently, some metric reporters keep an internal Map keyed by the metric object to keep track of the registered metric. The problem with the map with metric object as the key is that when the same metric object is registered with different names or metric groups, only the last registered metric will be reported.
> If I understand correctly, we do not forbid registering the same metric with different names or metric groups. For example, in `SchedulerBase#registerJobMetrics`, we register `numberOfRestarts` with two names, "numRestarts" and "fullRestarts". Unfortunately, in this case, the metric reporter will only report the fullRestarts metric, which is deprecated.
> I found that the following metric reporters have the problem, Influxdb metric reporter, Datadog metric reporter, and Dropwizard metric reporter.
> One possible fix is to swap the key and value of the internal map in the metric reporter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)