[GitHub] [airflow] jedcunningham commented on a diff in pull request #25323: Add `operator` and `has_outlet_datasets` to `/grid_data`

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25323:
URL: https://github.com/apache/airflow/pull/25323#discussion_r931678578


##########
airflow/www/views.py:
##########
@@ -353,6 +354,8 @@ def set_overall_state(record):
                 'label': item.label,
                 'extra_links': item.extra_links,
                 'is_mapped': item.is_mapped,
+                'has_outlet_datasets': any(isinstance(i, Dataset) for i in getattr(item, "_outlets", [])),

Review Comment:
   So I just played with this a bit, and while you can set an outlet in partial, it doesn't actually function. (because it gets serialized into `outlets`?). We might need to investigate that sooner than later, but I'm not sure we should block this PR in the meantime so the UI effort can continue.
   
   The getattr was because mapped operators don't have `_outlets`, so while this doesn't "work", this also doesn't "break" things further.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org