You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/10/16 07:42:44 UTC
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14461
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
[common] Use EncodeKeyImpl() to handle different RowType
For different RowType, the processing logic in two overloaded
EncodeRow() is duplicated.
Change-Id: I5daf09a09c8916da1307b598be708588aa842803
---
M src/kudu/common/partition.cc
1 file changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/14461/1
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14461 )
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 04:02:09 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14461
to look at the new patch set (#2).
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
[common] Use EncodeKeyImpl() to handle different RowType
For different RowType, the processing logic in two overloaded
EncodeRow() is duplicated.
Change-Id: I5daf09a09c8916da1307b598be708588aa842803
---
M src/kudu/common/partition.cc
1 file changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/14461/2
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14461 )
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
[common] Use EncodeKeyImpl() to handle different RowType
For different RowType, the processing logic in two overloaded
EncodeRow() is duplicated.
Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Reviewed-on: http://gerrit.cloudera.org:8080/14461
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/partition.cc
1 file changed, 7 insertions(+), 10 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14461 )
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/14461/1/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/14461/1/src/kudu/common/partition.cc@202
PS1, Line 202: std::
> Don't need this.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 01:24:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14461 )
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 05:01:20 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Use EncodeKeyImpl() to handle different RowType
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14461 )
Change subject: [common] Use EncodeKeyImpl() to handle different RowType
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14461/1/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/14461/1/src/kudu/common/partition.cc@202
PS1, Line 202: std::
Don't need this.
--
To view, visit http://gerrit.cloudera.org:8080/14461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5daf09a09c8916da1307b598be708588aa842803
Gerrit-Change-Number: 14461
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 16 Oct 2019 16:15:36 +0000
Gerrit-HasComments: Yes