You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/09/21 20:28:40 UTC
Review Request 62481: Fixed tests impacted by no longer removing the
agent symlink.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445
Repository: mesos
Description
-------
This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.
Diffs
-----
src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
Diff: https://reviews.apache.org/r/62481/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review185929
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', '62481']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481/logs/mesos-tests-build-cmake-stdout.log):
```
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
c:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
c:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [C:\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\mesos.vcxproj" (default target) (12) ->
"C:\mesos\src\mesos-protobufs.vcxproj" (default target) (13) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [C:\mesos\src\mesos-protobufs.vcxproj]
60 Warning(s)
1 Error(s)
Time Elapsed 00:02:38.67
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_1d74a.dir\Debug\cmTC_1d74a.tlog\".
InitializeBuildStatus:
Creating "cmTC_1d74a.dir\Debug\cmTC_1d74a.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_1d74a.dir\Debug\" /Fd"cmTC_1d74a.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_1d74a.dir\Debug\" /Fd"cmTC_1d74a.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1d74a.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1d74a.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1d74a.lib" /MACHINE:X64 /machine:x64 cmTC_1d74a.dir\Debug\src.obj
cmTC_1d74a.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1d74a.exe
cmTC_1d74a.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1d74a.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_1d74a.dir\Debug\cmTC_1d74a.tlog\unsuccessfulbuild".
Touching "cmTC_1d74a.dir\Debug\cmTC_1d74a.tlog\cmTC_1d74a.lastbuildstate".
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_1d74a.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:02.43
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62481/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_376c3.dir\Debug\".
Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_376c3.dir\Debug\cmTC_376c3.tlog\".
InitializeBuildStatus:
Creating "cmTC_376c3.dir\Debug\cmTC_376c3.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_376c3.dir\Debug\" /Fd"cmTC_376c3.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_376c3.dir\Debug\" /Fd"cmTC_376c3.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_376c3.vcxproj]
Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_376c3.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\mesos\CMakeFiles\CMakeTmp\cmTC_376c3.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_376c3.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.24
```
- Mesos Reviewbot Windows
On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
> src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
> src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
>
>
> Diff: https://reviews.apache.org/r/62481/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186184
-----------------------------------------------------------
src/tests/gc_tests.cpp
Line 384 (original), 374 (patched)
<https://reviews.apache.org/r/62481/#comment262644>
What's the point of advancing the clock if the slave process is not up?
- Vinod Kone
On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
> src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
> src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
>
>
> Diff: https://reviews.apache.org/r/62481/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 8:45 p.m.)
Review request for .
Changes
-------
Review comments.
Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445
Repository: mesos
Description
-------
This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.
Review: https://reviews.apache.org/r/62481
Diffs (updated)
-----
src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
Diff: https://reviews.apache.org/r/62481/diff/3/
Changes: https://reviews.apache.org/r/62481/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 8:45 p.m.)
Review request for .
Changes
-------
Review comments.
Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445
Repository: mesos
Description
-------
This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.
Review: https://reviews.apache.org/r/62481
Diffs (updated)
-----
src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
Diff: https://reviews.apache.org/r/62481/diff/3/
Changes: https://reviews.apache.org/r/62481/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186310
-----------------------------------------------------------
src/tests/gc_tests.cpp
Line 381 (original)
<https://reviews.apache.org/r/62481/#comment262804>
I think we should wait until `__recover` gets executed to be sure that no gc has been scheduled.
- Vinod Kone
On Sept. 26, 2017, 4:59 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 4:59 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
>
> Review: https://reviews.apache.org/r/62481
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
> src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
> src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
>
>
> Diff: https://reviews.apache.org/r/62481/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 4:59 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-7445
https://issues.apache.org/jira/browse/MESOS-7445
Repository: mesos
Description (updated)
-------
This change fixes tests that relied on the agent work directory
symlink being removed when the agent receives the shutdown message
from the master.
Review: https://reviews.apache.org/r/62481
Diffs (updated)
-----
src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
Diff: https://reviews.apache.org/r/62481/diff/2/
Changes: https://reviews.apache.org/r/62481/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62481: Fixed tests impacted by no longer removing
the agent symlink.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62481/#review186185
-----------------------------------------------------------
src/tests/slave_recovery_tests.cpp
Line 3137 (original), 3137 (patched)
<https://reviews.apache.org/r/62481/#comment262645>
s/different/same/
- Vinod Kone
On Sept. 21, 2017, 8:28 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62481/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7445
> https://issues.apache.org/jira/browse/MESOS-7445
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change fixes tests that relied on the agent work directory
> symlink being removed when the agent receives the shutdown message
> from the master.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp 5581861e8ff834b4e79a51bef5f28aac7e7d259d
> src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312
> src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723
>
>
> Diff: https://reviews.apache.org/r/62481/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>