You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Doug Davies <da...@oclc.org> on 2014/09/15 19:37:34 UTC
Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/
-----------------------------------------------------------
Review request for shindig and Ryan Baxter.
Bugs: SHINDIG-1983
https://issues.apache.org/jira/browse/SHINDIG-1983
Repository: shindig
Description
-------
The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
Diffs
-----
trunk/features/src/main/javascript/features/core.io/io.js 1625072
Diff: https://reviews.apache.org/r/25650/diff/
Testing
-------
I've tested the following scenarios
renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
and
params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
and
neither defined
Thanks,
Doug Davies
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/#review53363
-----------------------------------------------------------
Crap. I just noticed I broke javascript unit tests. This is my first time dealing with this. Let me see what I can do.
- Doug Davies
On Sept. 15, 2014, 5:37 p.m., Doug Davies wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25650/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 5:37 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Bugs: SHINDIG-1983
> https://issues.apache.org/jira/browse/SHINDIG-1983
>
>
> Repository: shindig
>
>
> Description
> -------
>
> The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/core.io/io.js 1625072
>
> Diff: https://reviews.apache.org/r/25650/diff/
>
>
> Testing
> -------
>
> I've tested the following scenarios
>
> renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
>
> and
>
> params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
>
> and
>
> neither defined
>
>
> Thanks,
>
> Doug Davies
>
>
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/#review56550
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Oct. 14, 2014, 2:40 p.m., Doug Davies wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25650/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 2:40 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Bugs: SHINDIG-1983
> https://issues.apache.org/jira/browse/SHINDIG-1983
>
>
> Repository: shindig
>
>
> Description
> -------
>
> The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/core.io/io.js 1625072
> trunk/features/src/test/javascript/features/core.io/iotest.js 1515531
>
> Diff: https://reviews.apache.org/r/25650/diff/
>
>
> Testing
> -------
>
> I've tested the following scenarios
>
> renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
>
> and
>
> params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
>
> and
>
> neither defined
>
>
> Thanks,
>
> Doug Davies
>
>
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 2:40 p.m.)
Review request for shindig and Ryan Baxter.
Changes
-------
Fixed code review items. Added 1 new test.
Bugs: SHINDIG-1983
https://issues.apache.org/jira/browse/SHINDIG-1983
Repository: shindig
Description
-------
The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
Diffs (updated)
-----
trunk/features/src/main/javascript/features/core.io/io.js 1625072
trunk/features/src/test/javascript/features/core.io/iotest.js 1515531
Diff: https://reviews.apache.org/r/25650/diff/
Testing
-------
I've tested the following scenarios
renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
and
params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
and
neither defined
Thanks,
Doug Davies
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/#review56514
-----------------------------------------------------------
It looks like you're using 4 spaces instead of 2 spaces. Please use formatting that matches the surrounding code.
trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/25650/#comment96880>
Small nit: I'd prefer not to check specifically against the "undefined" keyword since it is not a restricted keyword and can be overwritten. Alternatively, checking typeof or params.hasOwnProperty() would suffice.
- Stanton Sievers
On Sept. 15, 2014, 7:19 p.m., Doug Davies wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25650/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 7:19 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Bugs: SHINDIG-1983
> https://issues.apache.org/jira/browse/SHINDIG-1983
>
>
> Repository: shindig
>
>
> Description
> -------
>
> The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/core.io/io.js 1625072
> trunk/features/src/test/javascript/features/core.io/iotest.js 1515531
>
> Diff: https://reviews.apache.org/r/25650/diff/
>
>
> Testing
> -------
>
> I've tested the following scenarios
>
> renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
>
> and
>
> params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
>
> and
>
> neither defined
>
>
> Thanks,
>
> Doug Davies
>
>
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/#review56432
-----------------------------------------------------------
Are there any reviewers than can review this?
- Doug Davies
On Sept. 15, 2014, 7:19 p.m., Doug Davies wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25650/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 7:19 p.m.)
>
>
> Review request for shindig and Ryan Baxter.
>
>
> Bugs: SHINDIG-1983
> https://issues.apache.org/jira/browse/SHINDIG-1983
>
>
> Repository: shindig
>
>
> Description
> -------
>
> The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/core.io/io.js 1625072
> trunk/features/src/test/javascript/features/core.io/iotest.js 1515531
>
> Diff: https://reviews.apache.org/r/25650/diff/
>
>
> Testing
> -------
>
> I've tested the following scenarios
>
> renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
>
> and
>
> params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
>
> and
>
> neither defined
>
>
> Thanks,
>
> Doug Davies
>
>
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by "Davies,Douglas" <da...@oclc.org>.
Has anyone had a chance to look at this? Just getting a feel as to if everyone thinks this is an acceptable fix.
doug
On Sep 15, 2014, at 3:19 PM, Doug Davies <da...@oclc.org>> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25650/
Review request for shindig and Ryan Baxter.
By Doug Davies.
Updated Sept. 15, 2014, 7:19 p.m.
Changes
fixed unit tests and made nocache undefined if never defined in render or request params
Bugs: SHINDIG-1983<https://issues.apache.org/jira/browse/SHINDIG-1983>
Repository: shindig
Description
The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
Testing
I've tested the following scenarios
renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
and
params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
and
neither defined
Diffs (updated)
* trunk/features/src/main/javascript/features/core.io/io.js (1625072)
* trunk/features/src/test/javascript/features/core.io/iotest.js (1515531)
View Diff<https://reviews.apache.org/r/25650/diff/>
Re: Review Request 25650: The NO_CACHE RenderParam does not appear to
affect makeRequest
Posted by Doug Davies <da...@oclc.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25650/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 7:19 p.m.)
Review request for shindig and Ryan Baxter.
Changes
-------
fixed unit tests and made nocache undefined if never defined in render or request params
Bugs: SHINDIG-1983
https://issues.apache.org/jira/browse/SHINDIG-1983
Repository: shindig
Description
-------
The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs.
Diffs (updated)
-----
trunk/features/src/main/javascript/features/core.io/io.js 1625072
trunk/features/src/test/javascript/features/core.io/iotest.js 1515531
Diff: https://reviews.apache.org/r/25650/diff/
Testing
-------
I've tested the following scenarios
renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false)
and
params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0)
and
neither defined
Thanks,
Doug Davies