[GitHub] [iceberg] wypoon commented on a change in pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox <gi...@apache.org>]

wypoon commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r702205292



##########
File path: core/src/main/java/org/apache/iceberg/BaseTable.java
##########
@@ -74,6 +75,57 @@ public Schema schema() {
     return ops.current().schemasById();
   }
 
+  /**
+   * Return the {@link Schema schema} for this table at the time of the snapshot
+   * specified by the snapshotId.
+   *
+   * @return the schema
+   */
+  public Schema schemaForSnapshot(long snapshotId) {

Review comment:
       I will remove this and the following method from `BaseTable`.
   I will move the recovery of schema from previous metadata files (in the event that a snapshot does not have a schema id associated with it) to a separate PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org