You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/12/20 17:34:34 UTC
Review Request 71933: ATLAS-3568: Performance improvements in writing
audit logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71933/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
Bugs: ATLAS-3568
https://issues.apache.org/jira/browse/ATLAS-3568
Repository: atlas
Description
-------
Atlas server generates audit logs on changes to entities - like add/remove classifications, entity attribute updates, etc. Add/remove of classifications to an entity can result in multiple entities to be updated due to tag-propagation. In such cases, the time taken to create audit logs can be reduced by writing audits for all updated entities in one call to the audit store, instead of current implementation that writes audit logs for one entity at a time.
Diffs
-----
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java d36582b07
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 706da1664
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java bd1ba5898
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 3fbcecb42
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7a2ccb977
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 8893380fe
Diff: https://reviews.apache.org/r/71933/diff/1/
Testing
-------
manually validated.
precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1595/console
Thanks,
Sarath Subramanian
Re: Review Request 71933: ATLAS-3568: Performance improvements in
writing audit logs
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71933/#review219088
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 20, 2019, 6:21 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71933/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 6:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3568
> https://issues.apache.org/jira/browse/ATLAS-3568
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas server generates audit logs on changes to entities - like add/remove classifications, entity attribute updates, etc. Add/remove of classifications to an entity can result in multiple entities to be updated due to tag-propagation. In such cases, the time taken to create audit logs can be reduced by writing audits for all updated entities in one call to the audit store, instead of current implementation that writes audit logs for one entity at a time.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java d36582b
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 706da16
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java bd1ba58
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 3fbcecb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7a2ccb9
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 8893380
>
>
> Diff: https://reviews.apache.org/r/71933/diff/2/
>
>
> Testing
> -------
>
> manually validated.
>
> precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1595/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71933: ATLAS-3568: Performance improvements in
writing audit logs
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71933/#review219087
-----------------------------------------------------------
Ship it!
Ship It!
- Saqeeb Shaikh
On Dec. 20, 2019, 6:21 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71933/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 6:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3568
> https://issues.apache.org/jira/browse/ATLAS-3568
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Atlas server generates audit logs on changes to entities - like add/remove classifications, entity attribute updates, etc. Add/remove of classifications to an entity can result in multiple entities to be updated due to tag-propagation. In such cases, the time taken to create audit logs can be reduced by writing audits for all updated entities in one call to the audit store, instead of current implementation that writes audit logs for one entity at a time.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java d36582b
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 706da16
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java bd1ba58
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 3fbcecb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7a2ccb9
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 8893380
>
>
> Diff: https://reviews.apache.org/r/71933/diff/2/
>
>
> Testing
> -------
>
> manually validated.
>
> precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1595/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71933: ATLAS-3568: Performance improvements in
writing audit logs
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71933/
-----------------------------------------------------------
(Updated Dec. 20, 2019, 10:21 a.m.)
Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian.
Bugs: ATLAS-3568
https://issues.apache.org/jira/browse/ATLAS-3568
Repository: atlas
Description
-------
Atlas server generates audit logs on changes to entities - like add/remove classifications, entity attribute updates, etc. Add/remove of classifications to an entity can result in multiple entities to be updated due to tag-propagation. In such cases, the time taken to create audit logs can be reduced by writing audits for all updated entities in one call to the audit store, instead of current implementation that writes audit logs for one entity at a time.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java d36582b
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 706da16
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java bd1ba58
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 3fbcecb
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7a2ccb9
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 8893380
Diff: https://reviews.apache.org/r/71933/diff/2/
Changes: https://reviews.apache.org/r/71933/diff/1-2/
Testing
-------
manually validated.
precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1595/console
Thanks,
Sarath Subramanian