[GitHub] [airflow] potiuk commented on pull request #19734: Custom deprecation proxy implementing __format__

[GitBox <gi...@apache.org>]

potiuk commented on pull request #19734:
URL: https://github.com/apache/airflow/pull/19734#issuecomment-974800618


   Idea @uranusjr  - seems that all those "deprecated" objects are `datetime' objects. Why don't we simply create an "Airflow datateime" which extends directly from datetime? we could override the class instance type to pass all the checks for `isinstance` and `issubclass` (obviously). This is less "generic" than using lazy_proxy, but it should behave much more "backwards-compatible" and serialization problems would be gone.
   
   We do not really use the "lazyness" of the proxy, this is perfectly fine to instantiate those objects at creation time (they will probably take less memory than the proxy anyway).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org