You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/04 00:06:29 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8740:
[filter_box] Fix show time column in filter_box
codecov-io edited a comment on issue #8740: [filter_box] Fix show time column in filter_box
URL: https://github.com/apache/incubator-superset/pull/8740#issuecomment-561413769
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=h1) Report
> Merging [#8740](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/43f637e403dea0e3ccf70c5fc2a81249b58b88ff?src=pr&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8740 +/- ##
==========================================
+ Coverage 65.67% 65.86% +0.19%
==========================================
Files 482 482
Lines 24102 24112 +10
Branches 2767 2767
==========================================
+ Hits 15828 15881 +53
+ Misses 8094 8055 -39
+ Partials 180 176 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRGaWx0ZXJDb25maWdzRnJvbUZvcm1kYXRhLmpz) | `90.47% <100%> (+47.61%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.85% <0%> (+0.03%)` | :arrow_up: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.52% <0%> (+0.04%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.09% <0%> (+0.04%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.95% <0%> (+0.13%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.5% <0%> (+0.22%)` | :arrow_up: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.66% <0%> (+0.3%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.81% <0%> (+0.49%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `84.37% <0%> (+5.42%)` | :arrow_up: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `84.13% <0%> (+8.93%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/8740/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=footer). Last update [43f637e...852bbed](https://codecov.io/gh/apache/incubator-superset/pull/8740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org