You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/25 10:14:32 UTC

[GitHub] [apisix] starsz commented on a diff in pull request #8162: fix: meta.filter in plugin doesn't work in response-rewrite plugin

starsz commented on code in PR #8162:
URL: https://github.com/apache/apisix/pull/8162#discussion_r1004280692


##########
apisix/plugin.lua:
##########
@@ -433,6 +438,8 @@ local function meta_filter(ctx, plugin_name, plugin_conf)
                          " plugin_name: ", plugin_name)
         return true
     end
+
+    ctx[match_cache_key] = ok

Review Comment:
   I think we can't cache the result of the filter. Since we have a different phase for every plugin like "rewrite", "access" e.g.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org