You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/13 02:42:59 UTC
[GitHub] [iotdb] LebronAl commented on a change in pull request #3939: init dummyIndex after restart cluster
LebronAl commented on a change in pull request #3939:
URL: https://github.com/apache/iotdb/pull/3939#discussion_r706962210
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/serializable/SyncLogDequeSerializer.java
##########
@@ -236,6 +237,24 @@ public LogManagerMeta getMeta() {
return getLogs(meta.getMaxHaveAppliedCommitIndex(), meta.getCommitLogIndex());
}
+ /**
+ * Recover un-committed logs but already persistent. Maybe,we can extract
Review comment:
This persistence strategy needs to be improved, such as persisting uncommitted logs to ensure that some of raft's corner cases are correct. But in currrent logic, this function doesn't seem to be working?
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##########
@@ -125,6 +127,8 @@ protected RaftLogManager(StableEntryManager stableEntryManager, LogApplier appli
long first = getCommittedEntryManager().getDummyIndex();
long last = getCommittedEntryManager().getLastIndex();
this.setUnCommittedEntryManager(new UnCommittedEntryManager(last + 1));
+ this.getUnCommittedEntryManager()
Review comment:
same as below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org