You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2023/07/31 11:53:24 UTC
[GitHub] [zookeeper] showuon opened a new pull request, #2041: ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses
showuon opened a new pull request, #2041:
URL: https://github.com/apache/zookeeper/pull/2041
Found 2 places we will compare the addresses to check if there's any major change, but the addresses comparison will compare `hostname` + `IP address` + `port`. If the DNS is slow, there might be chances that the `hostname` and `port` are identical, but the `IP address` has `<unresolved>` V.S. `x.x.x.x`. So the result will be the unexpected unequal.
This PR tried to recreateSocketAddresses before comparing the addresses to fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar merged PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1887036151
@eolivelli @symat @tisonkun @ztzg, please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2345336633
@anmolnar , conflicts resolved. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1768319061
@showuon You have checkstyle validation error
```
Error: /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java:43:1: Extra separation in import group before 'org.apache.jute.OutputArchive' [ImportOrder]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366425147
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java:
##########
@@ -253,13 +253,39 @@ public void testGetDesignatedLeaderShouldRecreateSocketAddresses() {
@Test
public void testRecreateSocketAddresses() {
+ InetAddress loopback = InetAddress.getLoopbackAddress();
+ String oldIP = loopback.getHostAddress();
+ String newIP = "1.1.1.1";
+
+ // test case 1: empty MultipleAddresses instance will still be empty after recreateSocketAddresses
MultipleAddresses multipleAddresses = new MultipleAddresses();
assertEquals(multipleAddresses, leader.recreateSocketAddresses(multipleAddresses));
- InetSocketAddress addr1 = new InetSocketAddress(InetAddress.getLoopbackAddress(), PortAssignment.unique());
- InetSocketAddress addr2 = new InetSocketAddress(InetAddress.getLoopbackAddress(), PortAssignment.unique());
+ // test case 2: The content of MultipleAddresses instance will still be the same after recreateSocketAddresses if address no change
+ InetSocketAddress addr1 = new InetSocketAddress(loopback, PortAssignment.unique());
+ InetSocketAddress addr2 = new InetSocketAddress(loopback, PortAssignment.unique());
multipleAddresses = new MultipleAddresses(Arrays.asList(addr1, addr2));
// Verify after recreateSocketAddresses, the multipleAddresses should be the same (i.e. under no DNS's interaction)
assertEquals(multipleAddresses, leader.recreateSocketAddresses(multipleAddresses));
+
+ // test case 3: Simulating the DNS returning different IP address for the same hostname during recreation.
+ // After recreateSocketAddresses, the MultipleAddresses should contain the updated IP address instance while other fields unchanged.
+ InetAddress spyInetAddr = Mockito.spy(loopback);
+ InetSocketAddress addr3 = new InetSocketAddress(spyInetAddr, PortAssignment.unique());
+ // Verify the address is the old IP before recreateSocketAddresses.
+ assertEquals(oldIP, addr3.getAddress().getHostAddress());
+ multipleAddresses = new MultipleAddresses(Arrays.asList(addr3));
+ // simulating the DNS returning different IP address
+ when(spyInetAddr.getHostAddress()).thenReturn(newIP);
+
+ // Verify after recreateSocketAddresses, the multipleAddresses should have different IP address result
+ MultipleAddresses newMultipleAddress = leader.recreateSocketAddresses(multipleAddresses);
+ assertNotEquals(multipleAddresses, newMultipleAddress);
+ assertEquals(1, multipleAddresses.getAllAddresses().size());
+ InetSocketAddress newAddr = multipleAddresses.getAllAddresses().iterator().next();
+ // Verify the hostName should still be the same
+ assertEquals(loopback.getHostName(), newAddr.getAddress().getHostName());
+ // Verify the IP address has changed.
+ assertEquals(newIP, newAddr.getAddress().getHostAddress());
Review Comment:
@anmolnar , added a test case to verify `recreateSocketAddress` return object is not the same as the input. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] showuon commented on pull request #2041: ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1676344160
@anmolnar , thanks for the comment. Tests added.
Note: It's not easy to test the slow DNS scenario, so I tried to verify the method is invoked as expected, alternatively.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1744309081
@anmolnar , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1839920092
@eolivelli @symat @tisonkun @ztzg, please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366873201
##########
pom.xml:
##########
@@ -703,6 +703,11 @@
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>${mockito.version}</version>
+ </dependency>
Review Comment:
I think that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2346580733
Merged. Thanks for the contribution @showuon !
I cannot backport to `branch-3.9` , because it has conflicts. Please open new PR if you'd like to backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1768374981
> @showuon You have checkstyle validation error
>
> ```
> Error: /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java:43:1: Extra separation in import group before 'org.apache.jute.OutputArchive' [ImportOrder]
> ```
@anmolnar , fixed. Please also help backport to 3.8/3.9 branch if no other comments. Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366873201
##########
pom.xml:
##########
@@ -703,6 +703,11 @@
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>${mockito.version}</version>
+ </dependency>
Review Comment:
I think that's fine, but I think you should add test scope to it.
```
<scope>test</scope>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "see-quick (via GitHub)" <gi...@apache.org>.
see-quick commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1774760243
We have encountered an issue affecting over 50% of the test cases within our testing infrastructure. We would greatly appreciate it if we could move forward with addressing this issue.
^^ @eolivelli, @symat, @tisonkun, and @ztzg
I appreciate your attention to this matter in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1853752224
@eolivelli @symat @tisonkun @ztzg, please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] showuon commented on pull request #2041: ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1658224431
@symat @eolivelli , similar to https://github.com/apache/zookeeper/pull/2040 and https://github.com/apache/zookeeper/pull/1524. Call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] showuon commented on pull request #2041: ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1695150358
@anmolnar , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "karthick-ponnusamy (via GitHub)" <gi...@apache.org>.
karthick-ponnusamy commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2048381867
Will this be approved anytime soon? We would greatly appreciate if this was merged as our infrastructure is greatly affected by this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2344102995
@clemcvlcs @showuon
Sure, I'm happy to merge it. Please rebase and resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "clemcvlcs (via GitHub)" <gi...@apache.org>.
clemcvlcs commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-2317994946
@eolivelli @symat @tisonkun @ztzg
This PR is approved since one year now. Any chance you can have a look at this ?
We are also affected by this issue, probably as many other people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] sonatype-lift[bot] commented on pull request #2041: ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses
Posted by "sonatype-lift[bot] (via GitHub)" <gi...@apache.org>.
sonatype-lift[bot] commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1658220714
## Sonatype Lift is retiring
Sonatype Lift will be retiring on <b>Sep 12, 2023</b>, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.
<b>[📖 Read about the impacts and timeline](https://www.sonatype.com/lift-retirement)</b>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1768315269
retest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#issuecomment-1770124305
The compatibility test failed on java 11 in 3.6.3, but passed on java 8 in 3.6.3. I think it should be fine. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366423020
##########
pom.xml:
##########
@@ -703,6 +703,11 @@
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>${mockito.version}</version>
+ </dependency>
Review Comment:
Adding `mockito-inline` module to support final method mocking. See [here](https://davidvlijmincx.com/posts/mockito_mock_final_methods_and_classes/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366872958
##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java:
##########
@@ -253,13 +253,39 @@ public void testGetDesignatedLeaderShouldRecreateSocketAddresses() {
@Test
public void testRecreateSocketAddresses() {
+ InetAddress loopback = InetAddress.getLoopbackAddress();
+ String oldIP = loopback.getHostAddress();
+ String newIP = "1.1.1.1";
+
+ // test case 1: empty MultipleAddresses instance will still be empty after recreateSocketAddresses
MultipleAddresses multipleAddresses = new MultipleAddresses();
assertEquals(multipleAddresses, leader.recreateSocketAddresses(multipleAddresses));
- InetSocketAddress addr1 = new InetSocketAddress(InetAddress.getLoopbackAddress(), PortAssignment.unique());
- InetSocketAddress addr2 = new InetSocketAddress(InetAddress.getLoopbackAddress(), PortAssignment.unique());
+ // test case 2: The content of MultipleAddresses instance will still be the same after recreateSocketAddresses if address no change
+ InetSocketAddress addr1 = new InetSocketAddress(loopback, PortAssignment.unique());
+ InetSocketAddress addr2 = new InetSocketAddress(loopback, PortAssignment.unique());
multipleAddresses = new MultipleAddresses(Arrays.asList(addr1, addr2));
// Verify after recreateSocketAddresses, the multipleAddresses should be the same (i.e. under no DNS's interaction)
assertEquals(multipleAddresses, leader.recreateSocketAddresses(multipleAddresses));
+
+ // test case 3: Simulating the DNS returning different IP address for the same hostname during recreation.
+ // After recreateSocketAddresses, the MultipleAddresses should contain the updated IP address instance while other fields unchanged.
+ InetAddress spyInetAddr = Mockito.spy(loopback);
+ InetSocketAddress addr3 = new InetSocketAddress(spyInetAddr, PortAssignment.unique());
+ // Verify the address is the old IP before recreateSocketAddresses.
+ assertEquals(oldIP, addr3.getAddress().getHostAddress());
+ multipleAddresses = new MultipleAddresses(Arrays.asList(addr3));
+ // simulating the DNS returning different IP address
+ when(spyInetAddr.getHostAddress()).thenReturn(newIP);
+
+ // Verify after recreateSocketAddresses, the multipleAddresses should have different IP address result
+ MultipleAddresses newMultipleAddress = leader.recreateSocketAddresses(multipleAddresses);
+ assertNotEquals(multipleAddresses, newMultipleAddress);
+ assertEquals(1, multipleAddresses.getAllAddresses().size());
+ InetSocketAddress newAddr = multipleAddresses.getAllAddresses().iterator().next();
+ // Verify the hostName should still be the same
+ assertEquals(loopback.getHostName(), newAddr.getAddress().getHostName());
+ // Verify the IP address has changed.
+ assertEquals(newIP, newAddr.getAddress().getHostAddress());
Review Comment:
lgtm. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4708: recreateSocketAddresses before comparing addresses [zookeeper]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #2041:
URL: https://github.com/apache/zookeeper/pull/2041#discussion_r1366423020
##########
pom.xml:
##########
@@ -703,6 +703,11 @@
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>${mockito.version}</version>
+ </dependency>
Review Comment:
Adding `mockito-inline` module to support final method mocking (in `InetAddress` class). See [here](https://davidvlijmincx.com/posts/mockito_mock_final_methods_and_classes/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org