You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/06/01 21:57:28 UTC
Re: Review Request 59475: Provide additional logging for config audit
log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/
-----------------------------------------------------------
(Updated June 1, 2017, 9:57 p.m.)
Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
Bugs: AMBARI-21096
https://issues.apache.org/jira/browse/AMBARI-21096
Repository: ambari
Description
-------
Improve logging of ambari-config-changes.log to include names, timestamps, and versions.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 25b12de
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java cf6b717
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c244107
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 228cf79
Diff: https://reviews.apache.org/r/59475/diff/2/
Changes: https://reviews.apache.org/r/59475/diff/1-2/
Testing
-------
Verified on live cluster
Thanks,
Alejandro Fernandez
Re: Review Request 59475: Provide additional logging for config audit
log
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/#review176685
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Lines 1819 (patched)
<https://reviews.apache.org/r/59475/#comment250109>
This will print a nicely formatted string of config deltas (added, deleted, changed).
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
Lines 662 (patched)
<https://reviews.apache.org/r/59475/#comment250111>
The update actually happens here as opposed to the top in which a permission exception can still be thrown.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
Lines 673 (patched)
<https://reviews.apache.org/r/59475/#comment250110>
Print all of the config types
- Alejandro Fernandez
On June 1, 2017, 9:57 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59475/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 9:57 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
>
>
> Bugs: AMBARI-21096
> https://issues.apache.org/jira/browse/AMBARI-21096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve logging of ambari-config-changes.log to include names, timestamps, and versions.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 25b12de
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java cf6b717
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c244107
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 228cf79
>
>
> Diff: https://reviews.apache.org/r/59475/diff/2/
>
>
> Testing
> -------
>
> Verified on live cluster
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 59475: Provide additional logging for config audit
log
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/#review176689
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On June 1, 2017, 9:57 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59475/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 9:57 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
>
>
> Bugs: AMBARI-21096
> https://issues.apache.org/jira/browse/AMBARI-21096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve logging of ambari-config-changes.log to include names, timestamps, and versions.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 25b12de
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java cf6b717
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c244107
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 228cf79
>
>
> Diff: https://reviews.apache.org/r/59475/diff/2/
>
>
> Testing
> -------
>
> Verified on live cluster
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 59475: Provide additional logging for config audit
log
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/#review176808
-----------------------------------------------------------
Ship it!
- Swapan Shridhar
On June 1, 2017, 9:57 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59475/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 9:57 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
>
>
> Bugs: AMBARI-21096
> https://issues.apache.org/jira/browse/AMBARI-21096
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Improve logging of ambari-config-changes.log to include names, timestamps, and versions.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 25b12de
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java cf6b717
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c244107
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 228cf79
>
>
> Diff: https://reviews.apache.org/r/59475/diff/2/
>
>
> Testing
> -------
>
> Verified on live cluster
>
>
> Thanks,
>
> Alejandro Fernandez
>
>