You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/03 22:30:00 UTC
[jira] [Updated] (ARROW-10448) [Rust] PrimitiveArray::new can
create arrays not in spec
[ https://issues.apache.org/jira/browse/ARROW-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated ARROW-10448:
-----------------------------------
Labels: pull-request-available (was: )
> [Rust] PrimitiveArray::new can create arrays not in spec
> --------------------------------------------------------
>
> Key: ARROW-10448
> URL: https://issues.apache.org/jira/browse/ARROW-10448
> Project: Apache Arrow
> Issue Type: Bug
> Components: Rust
> Affects Versions: 3.0.0
> Reporter: Jorge Leitão
> Assignee: Jorge Leitão
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, PrimitiveArray::new passed with `null_count != 0` creates an array that does not follow the specification, as it is initialized with a {{None}} null bitmap but a non-zero null_count.
> This method also makes no attempt to check for the buffer's aligment, which leads to UB.
> Since a change in this method's signature requires a backward incompatible change, and it is only used in tests, I propose that we just remove it: we have good offers to create primitive arrays:
> * from an {{ArrayData}},
> * from a vector or vector of optionals
> * from an iterator
> which covers all major cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)