[GitHub] jovany-wang edited a comment on issue #70: Optimize: optimize memory copy in MemoryBlock by move constructor and move assignment.

[GitBox <gi...@apache.org>]

jovany-wang edited a comment on issue #70: Optimize: optimize memory copy in MemoryBlock by move constructor and move assignment.
URL: https://github.com/apache/rocketmq-client-cpp/pull/70#issuecomment-455411708
 
 
   @ifplusor  Thanks for your explanations.
   I don't  think we should change `CRLF` to `LF` in a feature change  PR.
   It will make us confused for your changes.
   
   I think it's better to request another PR to do the `CRLF` change.
   In this PR, just to do the Optimization, so that we could read what you changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services