You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/03 13:00:30 UTC

[GitHub] [druid] kfaraz commented on a change in pull request #11988: Update tutorial-compaction.md to change an unclear statement

kfaraz commented on a change in pull request #11988:
URL: https://github.com/apache/druid/pull/11988#discussion_r761913713



##########
File path: docs/tutorials/tutorial-compaction.md
##########
@@ -90,7 +90,7 @@ We have included a compaction task spec for this tutorial datasource at `quickst
 
 This will compact all segments for the interval `2015-09-12/2015-09-13` in the `compaction-tutorial` datasource.
 
-The parameters in the `tuningConfig` control how many segments will be present in the compacted set of segments.
+The parameters in the `tuningConfig` gives control of how many maximum rows will be present in each segments, among other tuning configurations.

Review comment:
       Maybe retain some of the original language too (about the no. of segments) as it connects with the next paragraph.
   
   ```suggestion
   The parameters in the `tuningConfig` control the maximum number rows present in each compacted segment and thus affect the number of segments created by compaction.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org