[GitHub] rafaelweingartner commented on a change in pull request #3062: Fix null pointer exception when using ConfigKey.Scope.ManagementServer

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #3062: Fix null pointer exception when using ConfigKey.Scope.ManagementServer
URL: https://github.com/apache/cloudstack/pull/3062#discussion_r236678635
 
 

 ##########
 File path: framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
 ##########
 @@ -74,18 +74,28 @@
     List<ScopedConfigStorage> _scopedStorages;
     Set<Configurable> _configured = Collections.synchronizedSet(new HashSet<Configurable>());
 
-    HashMap<String, Pair<String, ConfigKey<?>>> _allKeys = new HashMap<String, Pair<String, ConfigKey<?>>>(1007);
+    private HashMap<String, Pair<String, ConfigKey<?>>> _allKeys = new HashMap<String, Pair<String, ConfigKey<?>>>(1007);
 
     HashMap<ConfigKey.Scope, Set<ConfigKey<?>>> _scopeLevelConfigsMap = new HashMap<ConfigKey.Scope, Set<ConfigKey<?>>>();
 
     public ConfigDepotImpl() {
         ConfigKey.init(this);
+        createEmptyScopeLevelMappings();
+    }
+
+    /**
+     * Create an empty map of ConfigKey.Scope values, setting the _scopeLevelConfigsMap with the created map
+     * This map must contain all ConfigKey.Scope values, except by the ConfigKey.Scope.Global.  
 
 Review comment:
   I do not think you need the `by` word there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services