You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/09/01 19:02:39 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #857: nimble/hs: remove recursive call

andrzej-kaczmarek commented on a change in pull request #857:
URL: https://github.com/apache/mynewt-nimble/pull/857#discussion_r481367440



##########
File path: nimble/host/src/ble_hs_conn.c
##########
@@ -552,7 +554,7 @@ ble_hs_conn_timer(void)
      */
     if (conn_handle != BLE_HS_CONN_HANDLE_NONE) {
         ble_gap_terminate(conn_handle, BLE_ERR_REM_USER_CONN_TERM);
-        return ble_hs_conn_timer();
+        goto again;

Review comment:
       you need to update comment as well
   and `while` or `do {} while` would be nicer than `goto`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org