[jira] [Resolved] (HDFS-16826) [RBF SBN] ConnectionManager should advance the client stateId for every request

["ZanderXu (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ZanderXu resolved HDFS-16826.
-----------------------------
    Fix Version/s: 3.4.0
     Hadoop Flags: Reviewed
       Resolution: Fixed

> [RBF SBN] ConnectionManager should advance the client stateId for every request
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-16826
>                 URL: https://issues.apache.org/jira/browse/HDFS-16826
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> ConnectionManager should advance the client stateId for every request whatever pool is null or not.
>  
> Bug Code as bellow:
> {code:java}
> // Create the pool if not created before
> if (pool == null) {
>   writeLock.lock();
>   try {
>     pool = this.pools.get(connectionId);
>     if (pool == null) {
>       pool = new ConnectionPool(
>           this.conf, nnAddress, ugi, this.minSize, this.maxSize,
>           this.minActiveRatio, protocol,
>           new PoolAlignmentContext(this.routerStateIdContext, nsId));
>       this.pools.put(connectionId, pool);
>       this.connectionPoolToNamespaceMap.put(connectionId, nsId);
>     }
>     // BUG Here
>     long clientStateId = RouterStateIdContext.getClientStateIdFromCurrentCall(nsId);
>     pool.getPoolAlignmentContext().advanceClientStateId(clientStateId);
>   } finally {
>     writeLock.unlock();
>   }
> } {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org