You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2024/09/02 14:32:54 UTC
[PR] UI API Add views tests [airflow]
pierrejeambrun opened a new pull request, #41957:
URL: https://github.com/apache/airflow/pull/41957
Small PR that add sample tests for views of the new UI API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2325165526
@bbovenzi @pierrejeambrun @potiuk What will be our strategy for migrating the API endpoints to the new UI API? Are we planning to do a lift and shift or are we planning to change some parts while moving them? I think we can start migrating API endpoints after this PR. Please correct me if I am wrong, we don't need to wait for follow-up work items listed here https://github.com/apache/airflow/pull/41798#issue-2489687636. We can test the endpoints locally in parallel with those works. I wanted to align with you before starting work on migrating endpoints to the UI API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2328112207
Well there's been follow up on that `re-wiring` thing, we discuss with Brent and we will most likely keep the old endpoints with the old UI working for airflow 3 development, without re-wiring there because we want to modify/break some endpoints and that would require effort on updating the old UI (that will be deleted soon anyway).
So the idea will be to follow the same strategy as for the front-end views. Duplicate, limit contributions on the old RestAPI and make the new UI Rest API rich enough so the old one can then be deleted.
Brent already wrote something here https://github.com/apache/airflow/pull/41903 if you want more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2324891810
I need to add the CI integration. (i.e extends the API test suite)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2325847567
> I'll write the documentation down, If we are happy with it and agree with the general strategy I can present it to the rest of the community. (This thurday if I manage to do it before then or at the next call)
Fantastic !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2325848950
And even if we have no write-up - we can just intiate the discussion and outline the idea this Thursday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2329868009
@bbovenzi @pierrejeambrun Amazing, thanks both! Yeah, I agree with both of you, if we are going to make changes then it would be hard to keep up. We will benefit from defining these things, at least from a higher level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2325174195
> What will be our strategy for migrating the API endpoints
I think it's a good topic to discuss at the next dev call (this Thursday)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #41957:
URL: https://github.com/apache/airflow/pull/41957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2329124923
@bugraoz93 I just started a thread in the dev list too. Trying to get the old UI to use the new rest API will create a lot of work for us that we will just have to delete soon, especially if we want to redesign some endpoints. So I think the best course of action is to have duplicate code for a short time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2327551827
@pierrejeambrun Awesome! Rewiring is a great idea to reduce duplication and minimize effort. I will follow up on PRs. Thanks for the details!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI API Add views tests [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #41957:
URL: https://github.com/apache/airflow/pull/41957#issuecomment-2325806974
[bugraoz93](https://github.com/bugraoz93) I would that the initial idea is to just migrate existing endpoints to the new API (FastAPI), modifying only endpoints if necessary so we can re-wire the old UI on new endpoints and be sure that things are working as expected. Also this will minimize the migration effort.
Then we can take airflow 3 opportunity to bring any breaking change that we need to the public part of the API if we feel like the restructuration should be done.
I am not sur we are fully ready to start the migration yet. Very close for 'private' endpoints i.e `/objects` but for the public one I will still need to figure out the `auto-generation` part of front end code. (types).
I would say that we can start migrating once:
- Permissions are handled in the new API so we can also move the existing permission set to the new UI
- UI is re-wired on this new API (so we can safely delete the old endpoint and minimize code duplication)
> I think it's a good topic to discuss at the next dev call (this Thursday)
I'll try to write the documentation down by then, and If we are happy with it and agree with the general strategy I can present it to the rest of the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org