You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2007/12/06 14:58:28 UTC

svn commit: r601736 - /lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java

Author: andreas
Date: Thu Dec  6 05:58:27 2007
New Revision: 601736

URL: http://svn.apache.org/viewvc?rev=601736&view=rev
Log:
[Refactoring] extracted constants

Modified:
    lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java

Modified: lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java
URL: http://svn.apache.org/viewvc/lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java?rev=601736&r1=601735&r2=601736&view=diff
==============================================================================
--- lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java (original)
+++ lenya/branches/branch_1_2_x_shibboleth/src/java/org/apache/shibboleth/impl/AssertionConsumerServiceImpl.java Thu Dec  6 05:58:27 2007
@@ -58,6 +58,10 @@
 public class AssertionConsumerServiceImpl extends AbstractLogEnabled implements
         AssertionConsumerService, Serviceable, Contextualizable {
 
+    public static final String REQ_PARAM_TARGET = "TARGET";
+    public static final String REQ_PARAM_SAMLART = "SAMLart";
+    public static final String REQ_PARAM_SAMLRESPONSE = "SAMLResponse";
+
     protected static final String CHARSET = "UTF-8";
 
     /**
@@ -141,11 +145,11 @@
 
     private BrowserProfileRequest getBrowserProfileRequest(HttpServletRequest req) {
         BrowserProfileRequest bpr = new BrowserProfileRequest();
-        bpr.SAMLResponse = req.getParameter("SAMLResponse");
-        bpr.TARGET = req.getParameter("TARGET");
+        bpr.SAMLResponse = req.getParameter(REQ_PARAM_SAMLRESPONSE);
+        bpr.TARGET = req.getParameter(REQ_PARAM_TARGET);
         String[] samlArt = null;
         if (bpr.SAMLResponse == null)
-            samlArt = req.getParameterValues("SAMLart");
+            samlArt = req.getParameterValues(REQ_PARAM_SAMLART);
         bpr.SAMLArt = samlArt;
         return bpr;
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org