[GitHub] [apisix] Firstsawyou commented on a change in pull request #3053: feat: improve the error msg when client doesn't send SNI

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #3053:
URL: https://github.com/apache/apisix/pull/3053#discussion_r543218611



##########
File path: apisix/ssl/router/radixtree_sni.lua
##########
@@ -208,7 +208,9 @@ function _M.match_and_set(api_ctx)
     local sni
     sni, err = ngx_ssl.server_name()
     if type(sni) ~= "string" then
-        return false, "failed to fetch SSL certificate: " .. (err or "not found")
+        local advise = "please check if the client requests via IP or uses an outdated protocol" ..
+            ". If you need to report an issue, provide a packet capture file of the TLS handshake."

Review comment:
       I think it would be better to align the tips of `advise`, like this:
   
   ```
   local advise = "please check if the client requests via IP or uses an outdated protocol." ..
                  "If you need to report an issue, provide a packet capture file of the TLS handshake."
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org