You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/27 22:21:48 UTC
[GitHub] [helix] jiajunwang commented on a change in pull request #917:
minor fix for customized view aggregation
jiajunwang commented on a change in pull request #917: minor fix for customized view aggregation
URL: https://github.com/apache/helix/pull/917#discussion_r399561072
##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -139,7 +139,7 @@
final AtomicReference<Map<String, LiveInstance>> _lastSeenInstances;
final AtomicReference<Map<String, LiveInstance>> _lastSeenSessions;
- final AtomicReference<Set<String>> _lastSeenCustomizedStateTypes;
+ final AtomicReference<Map<String, Set<String>>> _lastSeenCustomizedStateTypesMap;
Review comment:
More comments about the content of the map, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org