You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "yangz (Code Review)" <ge...@cloudera.org> on 2019/01/30 07:06:54 UTC
[kudu-CR](branch-1.8.x) Kudu-2670 split more scanner and add concurrent
yangz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12305
Change subject: Kudu-2670 split more scanner and add concurrent
......................................................................
Kudu-2670 split more scanner and add concurrent
Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ConcurrentKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
A java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
A java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
A java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeResponse.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestConcurrentScanner.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRangeRequest.java
A java/kudu-client/src/test/java/org/apache/kudu/util/SplitTestUtil.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
14 files changed, 940 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/12305/1
--
To view, visit http://gerrit.cloudera.org:8080/12305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
Gerrit-Change-Number: 12305
Gerrit-PatchSet: 1
Gerrit-Owner: yangz <zh...@gmail.com>
[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent
Posted by "yangz (Code Review)" <ge...@cloudera.org>.
yangz has abandoned this change. ( http://gerrit.cloudera.org:8080/12305 )
Change subject: KUDU-2670: split more scanner and add concurrent
......................................................................
Abandoned
rebase to master instead of branch-1.8.x
--
To view, visit http://gerrit.cloudera.org:8080/12305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
Gerrit-Change-Number: 12305
Gerrit-PatchSet: 2
Gerrit-Owner: yangz <zh...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: yangz <zh...@gmail.com>
[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent
Posted by "yangz (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12305
to look at the new patch set (#2).
Change subject: KUDU-2670: split more scanner and add concurrent
......................................................................
KUDU-2670: split more scanner and add concurrent
Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ConcurrentKuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
A java/kudu-client/src/main/java/org/apache/kudu/client/KeyRange.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
A java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeRequest.java
A java/kudu-client/src/main/java/org/apache/kudu/client/SplitKeyRangeResponse.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestConcurrentScanner.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestSplitKeyRangeRequest.java
A java/kudu-client/src/test/java/org/apache/kudu/util/SplitTestUtil.java
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
14 files changed, 940 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/12305/2
--
To view, visit http://gerrit.cloudera.org:8080/12305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
Gerrit-Change-Number: 12305
Gerrit-PatchSet: 2
Gerrit-Owner: yangz <zh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12305 )
Change subject: KUDU-2670: split more scanner and add concurrent
......................................................................
Patch Set 2:
Thanks for uploading this. I will take a look soon.
Given this is a new feature, we won't be able to submit it to the 1.8.x branch. If you would like it to be reviewed for the purpose of being committed it should be rebased on master.
If you would prefer not to rebase and address reviews let me know and I would be happy to help out.
--
To view, visit http://gerrit.cloudera.org:8080/12305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
Gerrit-Change-Number: 12305
Gerrit-PatchSet: 2
Gerrit-Owner: yangz <zh...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Jan 2019 21:48:57 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) KUDU-2670: split more scanner and add concurrent
Posted by "yangz (Code Review)" <ge...@cloudera.org>.
yangz has posted comments on this change. ( http://gerrit.cloudera.org:8080/12305 )
Change subject: KUDU-2670: split more scanner and add concurrent
......................................................................
Patch Set 2:
> Thanks for uploading this. I will take a look soon.
>
> Given this is a new feature, we won't be able to submit it to the
> 1.8.x branch. If you would like it to be reviewed for the purpose
> of being committed it should be rebased on master.
>
> If you would prefer not to rebase and address reviews let me know
> and I would be happy to help out.
Thanks for reply. I will rebase to master.
--
To view, visit http://gerrit.cloudera.org:8080/12305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d5952d1e534f03812ca1c9f3e8dbfd573e9caf2
Gerrit-Change-Number: 12305
Gerrit-PatchSet: 2
Gerrit-Owner: yangz <zh...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: yangz <zh...@gmail.com>
Gerrit-Comment-Date: Thu, 31 Jan 2019 03:03:50 +0000
Gerrit-HasComments: No