You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/22 10:16:28 UTC

[GitHub] [superset] Tonkonozhenko opened a new pull request #17197: feat(chart): Support ingressClassName

Tonkonozhenko opened a new pull request #17197:
URL: https://github.com/apache/superset/pull/17197


   ### SUMMARY
   Support ingressClassName in ingerss
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Tonkonozhenko commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
Tonkonozhenko commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-949487079


   @craig-rueda please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Tonkonozhenko commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
Tonkonozhenko commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-953593430


   @craig-rueda updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-951365397


   Looks like the linter still isn't happy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Tonkonozhenko commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
Tonkonozhenko commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-950566317


   @craig-rueda @jayakrishnankk thanks for the reminder. Version is bumped


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda closed pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
craig-rueda closed pull request #17197:
URL: https://github.com/apache/superset/pull/17197


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-953944015


   Closing this as it duplicates #17252 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jayakrishnankk commented on pull request #17197: feat(chart): Support ingressClassName

Posted by GitBox <gi...@apache.org>.
jayakrishnankk commented on pull request #17197:
URL: https://github.com/apache/superset/pull/17197#issuecomment-949939051


   Bump this: https://github.com/apache/superset/blob/26200b697a04ff9bf623fc4eb34f2726a35b9909/helm/superset/Chart.yaml#L25


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org