You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/04 02:13:53 UTC
[GitHub] [iceberg] felixYyu opened a new pull request, #4691: Static Analysis: Mixed Mutability Return Type
felixYyu opened a new pull request, #4691:
URL: https://github.com/apache/iceberg/pull/4691
This method returns both mutable and immutable collections or maps from different paths, I think it should `return ImmutableList.of();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4691: Static Analysis: Mixed Mutability Return Type
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4691:
URL: https://github.com/apache/iceberg/pull/4691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] felixYyu commented on pull request #4691: Static Analysis: Mixed Mutability Return Type
Posted by GitBox <gi...@apache.org>.
felixYyu commented on PR #4691:
URL: https://github.com/apache/iceberg/pull/4691#issuecomment-1117064387
Static Analysis waring, I think it better ImmutableList.of() @Fokko ```
iceberg\core\src\main\java\org\apache\iceberg\io\MultiBufferInputStream.java:179: [MixedMutabilityReturnType] This method returns both mutable and immutable collections or maps from different paths. This may be confusing for users of the method.
public List<ByteBuffer> sliceBuffers(long len) throws EOFException {
^
(see https://errorprone.info/bugpattern/MixedMutabilityReturnType)
Did you mean 'return ImmutableList.of();'?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org