You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/26 14:46:52 UTC
[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10219
Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates
......................................................................
java: fix a mistaken reference-equality check for BigDecimal predicates
KuduPredicate used == instead of .equals() to check whether a supplied
value was equal to the maximum value for the specified decimal type.
This could result in too-conservative pruning.
Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/10219/1
--
To view, visit http://gerrit.cloudera.org:8080/10219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
Gerrit-Change-Number: 10219
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
Gerrit-Change-Number: 10219
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10219 )
Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates
......................................................................
java: fix a mistaken reference-equality check for BigDecimal predicates
KuduPredicate used == instead of .equals() to check whether a supplied
value was equal to the maximum value for the specified decimal type.
This could result in too-conservative pruning.
Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
Reviewed-on: http://gerrit.cloudera.org:8080/10219
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
Gerrit-Change-Number: 10219
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.7.x) java: fix a mistaken reference-equality check for BigDecimal predicates
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10219 )
Change subject: java: fix a mistaken reference-equality check for BigDecimal predicates
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea49dcb3c3375287eb2c5fa704c1d9baea47b93
Gerrit-Change-Number: 10219
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 27 Apr 2018 03:31:39 +0000
Gerrit-HasComments: No