You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by cs...@apache.org on 2023/03/09 14:13:23 UTC
[impala] 01/07: IMPALA-11983: Update stale comments in sorter.h referencing Init()
This is an automated email from the ASF dual-hosted git repository.
csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 7a3b8e365fe65651c67a7b8892ad3513f317cd2e
Author: Daniel Becker <da...@cloudera.com>
AuthorDate: Tue Mar 7 16:05:07 2023 +0100
IMPALA-11983: Update stale comments in sorter.h referencing Init()
IMPALA-5446 replaced Sorter::Init() with Sorter::Prepare() and
Sorter::Open(), but comments in sorter.h still refer to Init().
This change updates these comments so they now refer to Prepare()
instead.
Change-Id: Ic3de8062d25cc226d5fea0cfb13a332e2e7f4aa4
Reviewed-on: http://gerrit.cloudera.org:8080/19599
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Daniel Becker <da...@cloudera.com>
---
be/src/runtime/sorter.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/runtime/sorter.h b/be/src/runtime/sorter.h
index 6b9785959..c83bf81cc 100644
--- a/be/src/runtime/sorter.h
+++ b/be/src/runtime/sorter.h
@@ -79,7 +79,7 @@ class RowBatch;
/// input run, and one batch is created to hold deep copied rows (i.e. ptrs + data) from
/// the output of the merge.
//
-/// Note that Init() must be called right after the constructor.
+/// Note that Prepare() must be called right after the constructor.
//
/// During a merge, one row batch is created for each input run, and one batch is created
/// for the output of the merge (if is not the final merge). It is assumed that the memory
@@ -151,7 +151,7 @@ class Sorter {
Status GetNext(RowBatch* batch, bool* eos) WARN_UNUSED_RESULT;
/// Resets all internal state like ExecNode::Reset().
- /// Init() must have been called, AddBatch()/GetNext()/InputDone()
+ /// Prepare() must have been called, AddBatch()/GetNext()/InputDone()
/// may or may not have been called.
void Reset();