You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/04/27 20:36:15 UTC

Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58815/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani.


Bugs: AMBARI-20880
    https://issues.apache.org/jira/browse/AMBARI-20880


Repository: ambari


Description
-------

Find keys require an update due to inheritance from Storm 1.0.1 from HDP2.5 onwards


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 898b120c0c 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml f42e0c8e49 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 285aff8c97 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml bc336bbf5e 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml fa3b496be1 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 9231c1222c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ec5f1bbfb6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 819363a3dc 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 2d2e01c000 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 557976c165 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 44a9bd86a1 


Diff: https://reviews.apache.org/r/58815/diff/1/


Testing
-------

Total run:1159
Total errors:0
Total failures:0
OK
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:43 min
[INFO] Finished at: 2017-04-27T12:52:07-07:00
[INFO] Final Memory: 69M/999M
[INFO] ------------------------------------------------------------------------
:ambari-server mradhakrishnan$ mvn clean test


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58815/#review173256
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On April 27, 2017, 4:36 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58815/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20880
>     https://issues.apache.org/jira/browse/AMBARI-20880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Find keys require an update due to inheritance from Storm 1.0.1 from HDP2.5 onwards
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 898b120c0c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml f42e0c8e49 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 285aff8c97 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml bc336bbf5e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml fa3b496be1 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 9231c1222c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ec5f1bbfb6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 819363a3dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 2d2e01c000 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 557976c165 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 44a9bd86a1 
> 
> 
> Diff: https://reviews.apache.org/r/58815/diff/1/
> 
> 
> Testing
> -------
> 
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:43 min
> [INFO] Finished at: 2017-04-27T12:52:07-07:00
> [INFO] Final Memory: 69M/999M
> [INFO] ------------------------------------------------------------------------
> :ambari-server mradhakrishnan$ mvn clean test
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 58815: Storm Log4J Regex Replacement on Upgrade Fails

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58815/#review173262
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On April 27, 2017, 8:36 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58815/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, Sumit Mohanty, and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-20880
>     https://issues.apache.org/jira/browse/AMBARI-20880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Find keys require an update due to inheritance from Storm 1.0.1 from HDP2.5 onwards
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java 5c0fba7fc6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 898b120c0c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml f42e0c8e49 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 285aff8c97 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml bc336bbf5e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml fa3b496be1 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 9231c1222c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml ec5f1bbfb6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 819363a3dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 2d2e01c000 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 557976c165 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 44a9bd86a1 
> 
> 
> Diff: https://reviews.apache.org/r/58815/diff/1/
> 
> 
> Testing
> -------
> 
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:43 min
> [INFO] Finished at: 2017-04-27T12:52:07-07:00
> [INFO] Final Memory: 69M/999M
> [INFO] ------------------------------------------------------------------------
> :ambari-server mradhakrishnan$ mvn clean test
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>