You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/10 06:22:52 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #33273: Refactor: Simplify code in breeze

uranusjr commented on code in PR #33273:
URL: https://github.com/apache/airflow/pull/33273#discussion_r1289612295


##########
dev/breeze/src/airflow_breeze/utils/run_utils.py:
##########
@@ -361,10 +361,8 @@ def commit_sha():
 
 def filter_out_none(**kwargs) -> dict:
     """Filters out all None values from parameters passed."""
-    for key in list(kwargs):
-        if kwargs[key] is None:
-            kwargs.pop(key)
-    return kwargs
+    return {key: val for key, val in kwargs.items() if val is not None}
+

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org