[GitHub] [hive] difin commented on a diff in pull request #4348: HIVE-27355: Iceberg: Create table can be slow due to file listing for…

["difin (via GitHub)" <gi...@apache.org>]

difin commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1202237428


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -511,12 +513,12 @@ public static void clearQuickStats(Map<String, String> params) {
     params.remove(StatsSetupConst.NUM_ERASURE_CODED_FILES);
   }
 
-  public static void updateTableStatsForCreateTable(Warehouse wh, Database db, Table tbl,
+  public static boolean updateTableStatsForCreateTable(Warehouse wh, Database db, Table tbl,

Review Comment:
   I added the boolean return to support the 2 new unit tests that I added for this method as part of this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org