[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3507: [KYUUBI #3441][WIP] Change default Spark version to 3.3.1

[GitBox <gi...@apache.org>]

Yikf commented on code in PR #3507:
URL: https://github.com/apache/incubator-kyuubi/pull/3507#discussion_r985105655


##########
.github/workflows/master.yml:
##########
@@ -385,10 +385,12 @@ jobs:
           kubectl create serviceaccount spark
           kubectl create clusterrolebinding spark-role --clusterrole=edit --serviceaccount=default:spark --namespace=default
           kubectl get serviceaccount
+      # TODO Support more Spark version
       - name: integration tests
         run: >-
           ./build/mvn ${MVN_OPT} clean install
           -Pflink-provided,hive-provided
+          -Pspark-3.2

Review Comment:
   It looks like that we currently support [spark 3.2](https://github.com/apache/incubator-kyuubi/blob/master/integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/spark/SparkOnKubernetesTestsSuite.scala#L48) only, We should specify the profile here to prevent some incompatibilities (on k8s w/ client)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org