You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "caican00 (via GitHub)" <gi...@apache.org> on 2023/07/14 06:16:41 UTC

[GitHub] [spark] caican00 opened a new pull request, #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

caican00 opened a new pull request, #42000:
URL: https://github.com/apache/spark/pull/42000

   ### What changes were proposed in this pull request?
   For such queries,
   ```
   where
   (date = 20221110 and udfStrLen(data) = 8)
   or
   (date = 20221111 and udfStrLen(data) = 8)  
   ```,
   we supports push down 'date = 20221110 or date = 20221111' predicate
   
   
   ### Why are the changes needed?
   Avoid full table scanning
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   New UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

Posted by "caican00 (via GitHub)" <gi...@apache.org>.
caican00 commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1635349047

   Could you help me to review this PR? 
   gently ping @huaxingao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

Posted by "caican00 (via GitHub)" <gi...@apache.org>.
caican00 commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1637272331

   Could you help me to review this PR?
   gently ping @huaxingao
   Thanks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

Posted by "caican00 (via GitHub)" <gi...@apache.org>.
caican00 commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1647298090

   gently ping @ulysses-you 
   Could you help to review this patch? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1789865589

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

Posted by "caican00 (via GitHub)" <gi...@apache.org>.
caican00 commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1635582614

   > Could you share the plan string before and after optimization?
   
   Thanks for reviewing. I added screenshots of before and after optimization to the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikf commented on pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down

Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #42000:
URL: https://github.com/apache/spark/pull/42000#issuecomment-1635406006

   Could you share the plan string before and after optimization?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42000: [SPARK-44419][SQL] Support to extract partial filters of datasource v2 table and push them down
URL: https://github.com/apache/spark/pull/42000


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org