You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by David Crossley <cr...@apache.org> on 2007/04/19 01:34:55 UTC
Re: svn commit: r530191 - /forrest/trunk/plugins/build.xml
I don't think that it is so simple, otherwise i would have
just done this yesterday. If a plugin declares 0.7 as its
lowest version number in its build.xml then this change
will not handle it.
cd ../whiteboard/plugins/
find . -name build.xml | xargs grep "0\.7"
... reveals seven such plugins.
-David
> Author: gmcdonald
> Date: Wed Apr 18 15:51:32 2007
> New Revision: 530191
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=530191
> Log:
> update versions
>
> Modified:
> forrest/trunk/plugins/build.xml
>
> Modified: forrest/trunk/plugins/build.xml
> URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/build.xml?view=diff&rev=530191&r1=530190&r2=530191
> ==============================================================================
> --- forrest/trunk/plugins/build.xml (original)
> +++ forrest/trunk/plugins/build.xml Wed Apr 18 15:51:32 2007
> @@ -176,15 +176,15 @@
> depends="clean, dist, docs, checkout-deployed-docs, deploy-plugins.xml">
> <echo>Deploying plugin documentation to the web server</echo>
> <if>
> - <contains string="${forrest.version}" substring="0.7"/>
> + <contains string="${forrest.version}" substring="0.8"/>
> <then>
> - <property name="docsVersion" value="0_70"/>
> + <property name="docsVersion" value="0_80"/>
> </then>
> <else>
> <if>
> - <contains string="${forrest.version}" substring="0.8"/>
> + <contains string="${forrest.version}" substring="0.9"/>
> <then>
> - <property name="docsVersion" value="0_80"/>
> + <property name="docsVersion" value="0_90"/>
> </then>
> <else>
> <!-- FIXME: the docs version number should be derived programmatically from the forrest.version in use
>
>
hard-coded version numbers plugins/build.xml (Was: svn commit: r530191)
Posted by David Crossley <cr...@apache.org>.
Gav... wrote:
>
> <quote who="David Crossley">
> > I don't think that it is so simple, otherwise i would have
> > just done this yesterday. If a plugin declares 0.7 as its
> > lowest version number in its build.xml then this change
> > will not handle it.
> >
> > cd ../whiteboard/plugins/
> > find . -name build.xml | xargs grep "0\.7"
> > ... reveals seven such plugins.
>
> Ah Ok, (I did wonder actually), so is adding in another <if><then> an
> appropriate action here.
It should be okay as another workaround. I will add
another step in the howto-release doc.
However really the aim is to get rid of these
hard-coded things. See the fixme note below.
-David
> >> Author: gmcdonald
> >> Date: Wed Apr 18 15:51:32 2007
> >> New Revision: 530191
> >>
> >> URL: http://svn.apache.org/viewvc?view=rev&rev=530191
> >> Log:
> >> update versions
> >>
> >> Modified:
> >> forrest/trunk/plugins/build.xml
> >>
> >> Modified: forrest/trunk/plugins/build.xml
> >> URL:
> >> http://svn.apache.org/viewvc/forrest/trunk/plugins/build.xml?view=diff&rev=530191&r1=530190&r2=530191
> >> ==============================================================================
> >> --- forrest/trunk/plugins/build.xml (original)
> >> +++ forrest/trunk/plugins/build.xml Wed Apr 18 15:51:32 2007
> >> @@ -176,15 +176,15 @@
> >> depends="clean, dist, docs, checkout-deployed-docs,
> >> deploy-plugins.xml">
> >> <echo>Deploying plugin documentation to the web server</echo>
> >> <if>
> >> - <contains string="${forrest.version}" substring="0.7"/>
> >> + <contains string="${forrest.version}" substring="0.8"/>
> >> <then>
> >> - <property name="docsVersion" value="0_70"/>
> >> + <property name="docsVersion" value="0_80"/>
> >> </then>
> >> <else>
> >> <if>
> >> - <contains string="${forrest.version}" substring="0.8"/>
> >> + <contains string="${forrest.version}" substring="0.9"/>
> >> <then>
> >> - <property name="docsVersion" value="0_80"/>
> >> + <property name="docsVersion" value="0_90"/>
> >> </then>
> >> <else>
> >> <!-- FIXME: the docs version number should be derived programmatically
> >> from the forrest.version in use
> >>
> >>
> >
>
>
> --
> Gav...
>
Re: svn commit: r530191 - /forrest/trunk/plugins/build.xml
Posted by "Gav..." <br...@brightontown.com.au>.
<quote who="David Crossley">
> I don't think that it is so simple, otherwise i would have
> just done this yesterday. If a plugin declares 0.7 as its
> lowest version number in its build.xml then this change
> will not handle it.
>
> cd ../whiteboard/plugins/
> find . -name build.xml | xargs grep "0\.7"
> ... reveals seven such plugins.
>
> -David
Ah Ok, (I did wonder actually), so is adding in another <if><then> an
appropriate action here.
Gav...
>
>> Author: gmcdonald
>> Date: Wed Apr 18 15:51:32 2007
>> New Revision: 530191
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=530191
>> Log:
>> update versions
>>
>> Modified:
>> forrest/trunk/plugins/build.xml
>>
>> Modified: forrest/trunk/plugins/build.xml
>> URL:
>> http://svn.apache.org/viewvc/forrest/trunk/plugins/build.xml?view=diff&rev=530191&r1=530190&r2=530191
>> ==============================================================================
>> --- forrest/trunk/plugins/build.xml (original)
>> +++ forrest/trunk/plugins/build.xml Wed Apr 18 15:51:32 2007
>> @@ -176,15 +176,15 @@
>> depends="clean, dist, docs, checkout-deployed-docs,
>> deploy-plugins.xml">
>> <echo>Deploying plugin documentation to the web server</echo>
>> <if>
>> - <contains string="${forrest.version}" substring="0.7"/>
>> + <contains string="${forrest.version}" substring="0.8"/>
>> <then>
>> - <property name="docsVersion" value="0_70"/>
>> + <property name="docsVersion" value="0_80"/>
>> </then>
>> <else>
>> <if>
>> - <contains string="${forrest.version}" substring="0.8"/>
>> + <contains string="${forrest.version}" substring="0.9"/>
>> <then>
>> - <property name="docsVersion" value="0_80"/>
>> + <property name="docsVersion" value="0_90"/>
>> </then>
>> <else>
>> <!-- FIXME: the docs version number should be derived programmatically
>> from the forrest.version in use
>>
>>
>
--
Gav...