You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 11:41:37 UTC
[GitHub] [spark] zhengruifeng commented on a change in pull request #26735:
[SPARK-30102][ML][PYSPARK] GMM supports instance weighting
zhengruifeng commented on a change in pull request #26735: [SPARK-30102][ML][PYSPARK] GMM supports instance weighting
URL: https://github.com/apache/spark/pull/26735#discussion_r352551174
##########
File path: mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala
##########
@@ -267,6 +268,18 @@ class GaussianMixtureSuite extends MLTest with DefaultReadWriteTest {
assert(trueLikelihood ~== floatLikelihood absTol 1e-6)
}
+ test("GMM support instance weighting") {
Review comment:
The final model is highly sensitive to the initlization, which is computed in `initRandom` and highly related to the data distribution & partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org