You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2016/09/01 16:27:25 UTC
[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/328
Nougat update - Updates required for API Level 24
This includes the ability to grab the build config and deliver it to plugins, which is important for obtaining the Application ID.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-android nougat_update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 7fc11450788e281d84202953d2e9ba10ae3e7276
Author: Joe Bowser <bo...@apache.org>
Date: 2016-06-20T22:50:35Z
Tweaks to fix possible breakage of the Whitelist plugin on Android
commit 1477bac489bae8d652cab85293f8af96ccb713dc
Author: Joe Bowser <bo...@apache.org>
Date: 2016-08-03T21:52:47Z
Adding Static Method to CoreAndroid Plugin so we can get the BuildConfig data from other plugins
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #328: Nougat update - Updates required for API Level 2...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/328
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/328?src=pr) is 33.78% (diff: 100%)
> Merging [#328](https://codecov.io/gh/apache/cordova-android/pull/328?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #328 diff @@
==========================================
Files 11 11
Lines 965 965
Methods 197 197
Messages 0 0
Branches 157 157
==========================================
Hits 326 326
Misses 639 639
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [047ed52...451be26](https://codecov.io/gh/apache/cordova-android/compare/047ed52d608742fbfcb7919011c7b4344e65e862...451be26325bfd89fb9d136e9a1be4d23334b3e7e?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...
Posted by pbakondy <gi...@git.apache.org>.
Github user pbakondy commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/328#discussion_r77677216
--- Diff: framework/src/org/apache/cordova/CoreAndroid.java ---
@@ -357,4 +358,33 @@ public void sendResumeEvent(PluginResult resumeEvent) {
}
}
}
+
+ /*
+ * This needs to be implemented if you wish to use the Camera Plugin or other plugins
+ * that read the Build Configuration.
+ *
+ * Thanks to Phil@Medtronic and Graham Borland for finding the answer and posting it to
+ * StackOverflow. This is annoying as hell!
+ *
+ */
+
+ public static Object getBuildConfigValue(Context ctx, String key)
--- End diff --
Notice: if you want to use this method within a ProGuard-obfuscated build the application will exit with `java.lang.ClassNotFoundException`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #328: Nougat update - Updates required for API ...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/328#discussion_r77679067
--- Diff: framework/src/org/apache/cordova/CoreAndroid.java ---
@@ -357,4 +358,33 @@ public void sendResumeEvent(PluginResult resumeEvent) {
}
}
}
+
+ /*
+ * This needs to be implemented if you wish to use the Camera Plugin or other plugins
+ * that read the Build Configuration.
+ *
+ * Thanks to Phil@Medtronic and Graham Borland for finding the answer and posting it to
+ * StackOverflow. This is annoying as hell!
+ *
+ */
+
+ public static Object getBuildConfigValue(Context ctx, String key)
--- End diff --
This class can't be used with ProGuard obfuscation, since it's a Cordova plugin in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org