You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2015/01/08 18:58:12 UTC
Review Request 29716: DRILL-1955: C++ client should provide a clean
method for detecting query completion in the async API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29716/
-----------------------------------------------------------
Review request for drill, Norris Lee and Xiao Meng.
Repository: drill-git
Description
-------
Added back the call to handleQryTerminatedState when the query COMPLETED status is received. Also added interface to get the query status.
Diffs
-----
contrib/native/client/src/clientlib/drillClient.cpp a8cfe8c
contrib/native/client/src/clientlib/drillClientImpl.cpp 84aa6cd
contrib/native/client/src/include/drill/drillClient.hpp 490c823
Diff: https://reviews.apache.org/r/29716/diff/
Testing
-------
Tested both sync and async APIs with multiple parallel queries.
Thanks,
Parth Chandra
Re: Review Request 29716: DRILL-1955: C++ client should provide a
clean method for detecting query completion in the async API.
Posted by Parth Chandra <pc...@maprtech.com>.
> On Jan. 8, 2015, 10:07 p.m., Norris Lee wrote:
> > Looks good to me. I'm not sure if this is your intention, but it's pretty much doing the same thing as it used to, where the state is returned with the DrillClientError in handleTerminatedQryState (which works perfectly fine for us).
Yes that is intentional, so that there is little impact on the ODBC driver. I did not want to use handleTerminatedQryState with an error for something that is clearly not an error and was afraid the sync API would break. But it does not and after testing it sufficiently to make sure it works OK, I reverted to the previous implementation.
- Parth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29716/#review67303
-----------------------------------------------------------
On Jan. 8, 2015, 5:58 p.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29716/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 5:58 p.m.)
>
>
> Review request for drill, Norris Lee and Xiao Meng.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added back the call to handleQryTerminatedState when the query COMPLETED status is received. Also added interface to get the query status.
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClient.cpp a8cfe8c
> contrib/native/client/src/clientlib/drillClientImpl.cpp 84aa6cd
> contrib/native/client/src/include/drill/drillClient.hpp 490c823
>
> Diff: https://reviews.apache.org/r/29716/diff/
>
>
> Testing
> -------
>
> Tested both sync and async APIs with multiple parallel queries.
>
>
> Thanks,
>
> Parth Chandra
>
>
Re: Review Request 29716: DRILL-1955: C++ client should provide a
clean method for detecting query completion in the async API.
Posted by Norris Lee <no...@simba.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29716/#review67303
-----------------------------------------------------------
Looks good to me. I'm not sure if this is your intention, but it's pretty much doing the same thing as it used to, where the state is returned with the DrillClientError in handleTerminatedQryState (which works perfectly fine for us).
- Norris Lee
On Jan. 8, 2015, 5:58 p.m., Parth Chandra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29716/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 5:58 p.m.)
>
>
> Review request for drill, Norris Lee and Xiao Meng.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added back the call to handleQryTerminatedState when the query COMPLETED status is received. Also added interface to get the query status.
>
>
> Diffs
> -----
>
> contrib/native/client/src/clientlib/drillClient.cpp a8cfe8c
> contrib/native/client/src/clientlib/drillClientImpl.cpp 84aa6cd
> contrib/native/client/src/include/drill/drillClient.hpp 490c823
>
> Diff: https://reviews.apache.org/r/29716/diff/
>
>
> Testing
> -------
>
> Tested both sync and async APIs with multiple parallel queries.
>
>
> Thanks,
>
> Parth Chandra
>
>