You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "sarankk (via GitHub)" <gi...@apache.org> on 2024/02/22 20:38:02 UTC

[PR] Update access of ClearSnapshotStrategy [cassandra-analytics]

sarankk opened a new pull request, #42:
URL: https://github.com/apache/cassandra-analytics/pull/42

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Re: [PR] CASSANDRASC-108 Update access of ClearSnapshotStrategy [cassandra-analytics]

Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on code in PR #42:
URL: https://github.com/apache/cassandra-analytics/pull/42#discussion_r1501293396


##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java:
##########
@@ -39,9 +39,9 @@
 
 import static org.apache.cassandra.spark.data.CassandraDataLayer.aliasLastModifiedTimestamp;
 
-public final class ClientConfig
+public class ClientConfig
 {
-    private static final Logger LOGGER = LoggerFactory.getLogger(ClientConfig.class);
+    protected static final Logger LOGGER = LoggerFactory.getLogger(ClientConfig.class);

Review Comment:
   ```suggestion
       protected final Logger logger = LoggerFactory.getLogger(this.getClass());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Re: [PR] CASSANDRA-19442 Update access of ClearSnapshotStrategy [cassandra-analytics]

Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #42:
URL: https://github.com/apache/cassandra-analytics/pull/42#issuecomment-1965475454

   Closed via https://github.com/apache/cassandra-analytics/commit/cf6de14d5b96ea173d6a1b2dad9bb64d563df06c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Re: [PR] CASSANDRA-19442 Update access of ClearSnapshotStrategy [cassandra-analytics]

Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh closed pull request #42: CASSANDRA-19442 Update access of ClearSnapshotStrategy
URL: https://github.com/apache/cassandra-analytics/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Re: [PR] CASSANDRA-19442 Update access of ClearSnapshotStrategy [cassandra-analytics]

Posted by "milkg0d (via GitHub)" <gi...@apache.org>.
milkg0d commented on PR #42:
URL: https://github.com/apache/cassandra-analytics/pull/42#issuecomment-2075854018

   ```
   [pom.xml.xlsx](https://github.com/apache/cassandra-analytics/files/15100379/pom.xml.xlsx)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org