[GitHub] [geode] upthewaterspout commented on a change in pull request #7145: GEODE-9854: Orphaned .drf file causing memory leak

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #7145:
URL: https://github.com/apache/geode/pull/7145#discussion_r760643634



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -5942,6 +5943,8 @@ void cleanupAfterCompaction(boolean compactFailed) {
     if (!compactFailed) {
       // all data has been copied forward to new oplog so no live entries remain
       getTotalLiveCount().set(0);
+      // No need for regionMap as there are no more live entries and .crf will be deleted
+      regionMap.set(new ConcurrentHashMap<>());

Review comment:
       I think this might be simpler if you just called `clear` on the regionMap? No need for a separate atomic reference to a region map.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org