You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 13:50:26 UTC

[GitHub] [flink] GJL commented on a change in pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test

GJL commented on a change in pull request #11600: [FLINK-14311] Relax restart checker to harden StreaminFileSink e2e test
URL: https://github.com/apache/flink/pull/11600#discussion_r401630599
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -731,7 +731,8 @@ function wait_for_restart_to_complete {
     local expected_num_restarts=$((current_num_restarts + 1))
 
     echo "Waiting for restart to happen"
-    while ! [[ ${current_num_restarts} -eq ${expected_num_restarts} ]]; do
+    while [[ ${current_num_restarts} -le ${expected_num_restarts} ]]; do
 
 Review comment:
   For the record, this should have been `-lt` and it was fixed before pushing to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services